Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4289 - Ability to skip SSL certificate validation on external recommenders #4318

Conversation

reckart
Copy link
Member

@reckart reckart commented Nov 21, 2023

What's in the PR

  • Added tests
  • Disabling certificate checks for WebHooks also disables host name checking
  • Can currently not disable host name checking when using the Java 11 HTTP client

How to test manually

  • Try disabling certificate checking and then connecting to different bad endpoints as listed on https://badssl.com

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…enders

- Added tests
- Disabling certificate checks for WebHooks also disables host name checking
- Can currently not disable host name checking when using the Java 11 HTTP client
@reckart reckart added this to the 30.0 milestone Nov 21, 2023
@reckart reckart self-assigned this Nov 21, 2023
@reckart reckart force-pushed the feature/4289-Ability-to-skip-SSL-certificate-validation-on-external-recommenders branch from ce9ee8c to df2554f Compare November 21, 2023 20:08
@reckart reckart changed the base branch from main to release/29.x November 22, 2023 06:14
@reckart reckart merged commit b7aca06 into release/29.x Nov 22, 2023
1 check passed
@reckart reckart deleted the feature/4289-Ability-to-skip-SSL-certificate-validation-on-external-recommenders branch November 22, 2023 21:01
@reckart reckart modified the milestones: 30.0, 29.9 Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant